This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix loading bug on anomalies live chart #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
reviewed
May 11, 2020
| true | ||
| ); | ||
| // need to initially check if there is an error when accessing anomaly results index | ||
| // in the case that it doesn't exist upon cluster initialization |
There was a problem hiding this comment.
Good catch. Can you help check if other places have similar issue? Like detector list page?
There was a problem hiding this comment.
checked - detector list page doesn't ping anomaly results idx
| dispatch, | ||
| -1, | ||
| 1, | ||
| true |
There was a problem hiding this comment.
what if you change this to false?
There was a problem hiding this comment.
wouldn't that change the functionality of the call? I think we just want to encapsulate any error here (which can definitely be caused by the index not existing yet) and set is loading to false.
ylwu-amzn
approved these changes
May 11, 2020
kaituo
approved these changes
May 11, 2020
ohltyler
added a commit
that referenced
this pull request
May 11, 2020
* Fix loading bug on live anomalies chart
ohltyler
added a commit
that referenced
this pull request
May 11, 2020
* Fix loading bug on live anomalies chart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds error checking to anomalies live chart in the case that .opendistro-anomaly-results index does not exist yet. Without error checking, chart was getting stuck in an infinite loading state. This fixes that.
Before:
After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.